[Rev80 Bug Fix] dual scratch disconnects client

[Blackii]

Hi all

i got problems i follow the [MEGA GUIDE] Rose Server Setup + Compiling + SQL & More on ragezone all ok its fine but when i want to make skill ingame i got error and disconet form server ,map server say Hack and so on here pic of it



Sry for my bad english

Edit by lmame:
Title changed.

[lmame]

Like I told you on msn, search in forum on how to update your csv files to match your client version, so look in "tools forum" for a tool that "converts" STB to csv.

And as it's in the rules, don't contact by msn for that... , search in forum first...

[lmame]

Ok I had someone else on msn on this and it seems there is a problem in the basic skill "Dual Scratch" place.
It gives you this error, worldserver side:

Invalid Skill id 79 for Splitter
User disconnected (Splitter)

It seems this error happens when you are using the latest csv.


Here is a fast workaround:
In file worldserver/worldpackets.cpp, function bool CWorldServer::pakStartSkill ( CPlayer* thisclient, CPacket* P ):

REPLACE:

Line number On/Off | Expand/Contract | Select all

1. if(skillnum>=MAX_SKILL)

BY:

Line number On/Off | Expand/Contract | Select all

1. if(skillnum>=MAX_SKILL&&skillnum!=79)

REPLACE:

Line number On/Off | Expand/Contract | Select all

1.    unsigned int skillid = thisclient->cskills[skillnum].id+thisclient->cskills[skillnum].level-1;

BY:

Line number On/Off | Expand/Contract | Select all

1.    unsigned int skillid=101;
2.    
3.     if(skillnum!=79)
4.     {
5.         skillid = thisclient->cskills[skillnum].id+thisclient->cskills[skillnum].level-1;
6.     }

And it should work now.

[Rescudo]

That's not a very flexible workaround, you are including a more permanent fix for this in Rev81, right?

[lmame]

Last time I checked we hadn't the problem in rev81.
But you're free to look to understand why it's doing this of course. My guess is that the way skill lists are send to client is wrong (I mean it sends basic skills, then skills and so on), I saw that when doing packets stuff.
And as I said, it's a "fast workaround" milord. I'm so sorry I guess I shouldn't have give it since it's not perfect but everyone knows I code like shit

[Rescudo]

Chill lmame, just asked a question It does work for now, but you never know when they might change something at naROSE, in which case a more permanent fix would be useful.

[lmame]

Well you can't fix it for rev 80 anymore.
Why?
Because packet have changed so you can't capture them anymore to see how to send it the good way.
Moreover people are using new csv / sql with old packets so sometimes all you can do is dirty tricks.

[PurpleYouko]

Because packet have changed so you can't capture them anymore to see how to send it the good way.

What has changed?
I can still capture packets from NA Rose without any difficulty.
And I only started messing with them a few days ago

[Rescudo]

Rev80 still runs on the TRose-138 packet structure, while naROSE uses the new TRose-139 packets, so if there's any difference in these packets, we won't be able to log it for rev80

[PurpleYouko]

Rev80 still runs on the TRose-138 packet structure, while naROSE uses the new TRose-139 packets, so if there's any difference in these packets, we won't be able to log it for rev80

Oh crap. I was thinking along a completely different tack there.
I thought he was referring to some recent change that was making packet logging not work.

The difference between rev 80 packets and the new stuff is fairly minor in most cases. We know where those differences are as well so converting formats wouldn't be that difficult really if somebody was willing to put in the effort.
A lot of the packets are still exactly the same too.