Dev-Rev4 Updates

Welcome in the osRose emulator Project.

Moderators: osRose dev team, ospRose dev team, osiRose dev team, Moderators

Re: Dev-Rev4 Updates

Postby JediOfFreeSoft on Sun Jul 08, 2018 8:10 am

raventrix wrote:Hello Great devs of this forum!

Im not a programmer, but i can understand things! Currently we are trying to make a server out from this dev rev 4! Currently we can run the server and players can connect already! We are now fixing bugs one by one!

Heres the case: The case is about valor points. When we do the quest, it went just fine. Valor points was added when you finished the quests, the problem is when you relog, the valor points you've earned was removed! Any solution for this guys? hopefully somebody will help!


To fix this problem: Edit file QuestActions.cpp in the (WORLD SERVER/QUEST) folder

case 81: //LMA: Union Points (no break, it's NOT a mistake)...
{
if (curAbil->iType==81)
{
// client->CharInfo->union01+=curAbil->iValue; JEDI:
// client->CharInfo->union01+=curAbil->iValue*client->pc_up/100; JEDI:

client->CharInfo->Honor+=curAbil->iValue;
client->CharInfo->Honor+=curAbil->iValue*client->pc_up/100;
client->savedata(); // JEDI:
}

}
case 82:
{
if (curAbil->iType==82)
{

//client->CharInfo->union02+=curAbil->iValue; JEDI:
//client->CharInfo->union02+=curAbil->iValue*client->pc_up/100; JEDI:

client->CharInfo->Valor+=curAbil->iValue;
client->CharInfo->Valor+=curAbil->iValue*client->pc_up/100;
client->savedata(); // JEDI:
}
JediOfFreeSoft
Little soul
Little soul
 
Posts: 6
Joined: Sat Jun 16, 2018 2:27 pm

Re: Dev-Rev4 Updates

Postby PurpleYouko on Mon Jul 09, 2018 2:59 pm

so you are remapping Junon order and Akram Kingdom union points to valor and Honor?

You do realize that if you do this then the only way to get Valor and Honor will be to join one of those two unions and do union point quests.

The values 81 through 90 are all mapped directly to the 10 possible unions and is hard coded into all the QSD files.

have you tried looking in the QSD file for an NPC known to give Valor or Honor rewards? Once you find one then you will be able to use the reward type attribute to make two new conditionals to give valor and Honor.
Need to lookup information on NARose items, skills, quests?
Now featuring a newly completed skill tree for all classes
Formatting fixed for different resolutions
Image

"A Gazelle is nothing but a giraffe plotted logarithmicaly"
User avatar
PurpleYouko
Rose Guru
Rose Guru
 
Posts: 4599
Joined: Fri Aug 10, 2007 2:05 pm

Re: Dev-Rev4 Updates

Postby PurpleYouko on Mon Jul 09, 2018 3:33 pm

If somebody can get me a set of QSD files which use Valor and Honor I will figure it out and recode it for you.
I've just checked through all my clients and none of them have the necessary QSDs. They are either too old to use Valor and Honor at all or they are so new that they have no QSDs at all

The reason it seems to work when you play the game but doesn't save is because the servers simply aren't handling the QSD for it. period.
We don't actually HAVE the QSD for it. What you are seeing is the client processing the QSDs that it has with absolutely no communication with the server at all.

Yet another reason why Dev Rev 4 was abandoned.
Need to lookup information on NARose items, skills, quests?
Now featuring a newly completed skill tree for all classes
Formatting fixed for different resolutions
Image

"A Gazelle is nothing but a giraffe plotted logarithmicaly"
User avatar
PurpleYouko
Rose Guru
Rose Guru
 
Posts: 4599
Joined: Fri Aug 10, 2007 2:05 pm

Re: Dev-Rev4 Updates

Postby AnimalCrackerz on Mon Jul 09, 2018 5:22 pm

Don't want to contradict you PY, but in Dev4 they did away with Union Points and changed the quests to give Valor and Honor Points. You still do Faction/Union Fetch quests but when you talk to the Faction NPC's they ask if you would like to add to the Valor or Honor to their Faction and send you on Fetch Quests for either Honor or Valor points. I did Notice though that this only covers 2 cases, and PY called them the Junon Order and Akram Kingdom...does anyone Know which Unions the other cases are I am going to do the quests and want to assign the correct type of reward (either Honor/Valor) ..Also thanks to Jedi.. points are updating and saving.
AnimalCrackerz
Pomic
Pomic
 
Posts: 101
Joined: Tue Apr 20, 2010 1:58 pm

Re: Dev-Rev4 Updates

Postby PurpleYouko on Mon Jul 09, 2018 6:16 pm

That would entirely depend on the client you are using.
Rev 4 was/is coded to use union points as they always were. The client we built it for still had Union points.
If you are using a newer client then maybe this fix would work in the way you want.

Here is the function from my QSD editor that returns the text value that corresponds to the code number used in QUESTREWD(003) code
86 through 90 are normally not used but were reserved for future union expansions. I even used 89 for my own custom union in KTRose

  1.  
  2. Function GetSoption(ref) As String
  3. GetSoption = " Un-Defined " + CStr(ref)
  4. Select Case ref
  5.   Case 2
  6.     GetSoption = " Gender "
  7.   Case 3
  8.     GetSoption = " Birthstone "
  9.   Case 4
  10.     GetSoption = " Job "
  11.   Case 5
  12.     GetSoption = " Union "
  13.   Case 7
  14.     GetSoption = " Reputation "
  15.   Case 8
  16.     GetSoption = " Face "
  17.   Case 9
  18.     GetSoption = " Hair "
  19.   Case 10
  20.     GetSoption = " Strength "
  21.   Case 11
  22.     GetSoption = " Dexterity "
  23.   Case 12
  24.     GetSoption = " Inteligence "
  25.   Case 13
  26.     GetSoption = " Concentration "
  27.   Case 14
  28.     GetSoption = " Charm "
  29.   Case 15
  30.     GetSoption = " Sense "
  31.   Case 31
  32.     GetSoption = " Level "
  33.   Case 32
  34.     GetSoption = " Stat points "
  35.   Case 34
  36.     GetSoption = " PK Level "
  37.   Case 37
  38.     GetSoption = " Skill points "
  39.   Case 40
  40.     GetSoption = " Money "
  41.   Case 81
  42.     GetSoption = " Junon Order Union points "
  43.   Case 83
  44.     GetSoption = " Righteous Crusaders Union points "
  45.   Case 84
  46.     GetSoption = " Arumic Union points "
  47.   Case 85
  48.     GetSoption = " Ferrel Guild Union points "
  49.   Case 89
  50.     GetSoption = " Kuro-Tejina Union Points "   'Special union added into KTRose pre-evo client
  51.   End Select
  52. End Function


Can I get a look at the QSD files used for awarding Valor and Honor?
Absolutely none of my QSDs in any of my dozens of clients use it at all.
Need to lookup information on NARose items, skills, quests?
Now featuring a newly completed skill tree for all classes
Formatting fixed for different resolutions
Image

"A Gazelle is nothing but a giraffe plotted logarithmicaly"
User avatar
PurpleYouko
Rose Guru
Rose Guru
 
Posts: 4599
Joined: Fri Aug 10, 2007 2:05 pm

Previous

Return to Support - OsRose Emulator

Who is online

Users browsing this forum: No registered users and 5 guests