[Dev Rev 81.360] Craft bugs (don't stack)

Put your bugs you find in osRose here

Moderators: osRose dev team, ospRose dev team, osiRose dev team, Moderators

[Dev Rev 81.360] Craft bugs (don't stack)

Postby amaedict on Sun Aug 23, 2009 11:28 am

Crafting items dont stack.

Example : potions and grenades are meant to stack. but after crafting you only have one in inventory instead of 5.

anyone found this bug or a fix for it ?
Last edited by lmame on Tue Aug 25, 2009 9:52 am, edited 2 times in total.
Reason: Title changed.
We Have it all ... Image
Image
User avatar
amaedict
Clown
Clown
 
Posts: 531
Joined: Thu Apr 23, 2009 2:44 pm

Re: [Dev Rev 81.360] Craft bugs

Postby lmame on Sun Aug 23, 2009 11:52 am

What do you mean?
You had 4 in a slot and when you craft 1, you have 4 in a slot and 1 in another slot? or just ONE slot with 1 item?
The world is full of love and peace ^_^
Image
User avatar
lmame
Admin
Admin
 
Posts: 8997
Joined: Mon Aug 06, 2007 4:42 pm
Location: July City

Re: [Dev Rev 81.360] Craft bugs

Postby DoubleEagles on Sun Aug 23, 2009 12:02 pm

let me explain:

You craft for example a Hand Grenade. You see 1 item crafted in ur inventory.
You craft another Hand Grenade. You are stuck at only seeying 1 item in the inventory.

When you attack you just have 1 hand grenade. so it seems to delete the hand grenade you alrdy have
DoubleEagles
Rackie
Rackie
 
Posts: 225
Joined: Sat Dec 13, 2008 9:00 am

Re: [Dev Rev 81.360] Craft bugs

Postby lmame on Sun Aug 23, 2009 12:14 pm

Ok so the previous item is deleted?
What happens if you already have 5 had grenades? They are deleted and replaced by 1?
The world is full of love and peace ^_^
Image
User avatar
lmame
Admin
Admin
 
Posts: 8997
Joined: Mon Aug 06, 2007 4:42 pm
Location: July City

Re: [Dev Rev 81.360] Craft bugs

Postby DoubleEagles on Sun Aug 23, 2009 12:17 pm

Hold on, gonne check that ^^

EDIT:

Checked it.

I spawned 8 hand Grenades. Crafted 1. Only had 1 left in inventory.
DoubleEagles
Rackie
Rackie
 
Posts: 225
Joined: Sat Dec 13, 2008 9:00 am

Re: [Dev Rev 81.360] Craft bugs

Postby amaedict on Sun Aug 23, 2009 12:26 pm

yes that sounds right, thats the bug everyones reported.

after crafting it, try throwing the grenades out of inventory onto the ground, then pick them up again. i think this has been reported as a working around a few times.
We Have it all ... Image
Image
User avatar
amaedict
Clown
Clown
 
Posts: 531
Joined: Thu Apr 23, 2009 2:44 pm

Re: [Dev Rev 81.360] Craft bugs

Postby lmame on Sun Aug 23, 2009 12:38 pm

I guess you have to do a check for stackables items there in bool CWorldServer::pakCraft( CPlayer* thisclient, CPacket* P ) at this place:
  1. thisclient->items[newslot] = item;


So put BEFORE the line I told this code, something like this (not tested):
  1. if (item.itemtype>=10&&item.itemtype<=12)
  2. {
  3.     item.count+=thisclient->items[newslot].count;
  4. }



So you should have something like this:
  1.  
  2. if (item.itemtype>=10&&item.itemtype<=12)
  3. {
  4.     item.count+=thisclient->items[newslot].count;
  5. }
  6.  
  7. thisclient->items[newslot] = item;
The world is full of love and peace ^_^
Image
User avatar
lmame
Admin
Admin
 
Posts: 8997
Joined: Mon Aug 06, 2007 4:42 pm
Location: July City

Re: [Dev Rev 81.360] Craft bugs (don't stack)

Postby lmame on Tue Aug 25, 2009 9:39 am

Did someone tried??
The world is full of love and peace ^_^
Image
User avatar
lmame
Admin
Admin
 
Posts: 8997
Joined: Mon Aug 06, 2007 4:42 pm
Location: July City

Re: [Dev Rev 81.360] Craft bugs (don't stack)

Postby DoubleEagles on Tue Aug 25, 2009 9:46 am

This has been implented into our server code but we have a fixed maintenance hour tomorrow. But so far it worked on the test server we run :) and to what i've heard it worked fine. I can update more tomorrow once the new files are running :)
DoubleEagles
Rackie
Rackie
 
Posts: 225
Joined: Sat Dec 13, 2008 9:00 am

Re: [Dev Rev 81.360] Craft bugs (don't stack)

Postby lmame on Tue Aug 25, 2009 9:52 am

Ok :)
The world is full of love and peace ^_^
Image
User avatar
lmame
Admin
Admin
 
Posts: 8997
Joined: Mon Aug 06, 2007 4:42 pm
Location: July City

Next

Return to Bugs

Who is online

Users browsing this forum: No registered users and 5 guests

cron