[dev rev 360 client 249] Take control of Cart

[Choseal]

Client:
- NaRose 249

Server:
- OsRose 360 Dev Rev

Bug description:
- Player 1 gets on his cart;

- Player 1 uses the "Ride Request" skill on player 2, and player 2 accepts;

- While player 2 is on player one's cart, player 2 uses the "Ride Request" skill again;

- Using the arrow keys, Player 2 can now control player 1's cart;

- If player 1 gets of the cart, player 1 and 2's m-speed will go up by a certain amount;

- If a player, after getting the high m-speed, unequips a piece of armor, he is suddenly on a cart.

So that probably means you are actually on a cart when you get kicked off player 1's cart, but it's invisible, and you use the normal walk animation.

Also, the Shield Reflect skill isn't working, but I remembered Lmame saying he wont or cant fix skills?

[Choseal]

Worldserver, in: bool CWorldServer::pakRideRequest( CPlayer* thisclient, CPacket* P )

After:

Line number On/Off | Expand/Contract | Select all

1.    if(thisclient->Shop->open)
2.         return true;

Add:

Line number On/Off | Expand/Contract | Select all

1.    if (thisclient->Ride->Drive)
2.         return true;

[lmame]

Thanks, I'll add it in the dev rev II

[Sousie]

This code is not working for me. It prevents players from sending cart lift requests to other players. When i removed this code cart lift requests can be sent to other players.

[Raavi]

Rev 360 doesn't mean it works in devrev II i think it's already in there

[Sousie]

Yes its in Dev rev II now, it was added in revision 293, but I had to remove the code from worldpackets.cpp for cart lift request to work. So i don't know if its just me.

[lmame]

The player who's already riding can't send a request right? But the one "on foot" can, no?

[Sousie]

Players riding a cart can send the lift request but the lift request doesn't reach the other player on foot. Players on foot can also not send a cart lift request.

[lmame]

Weird. I'll check that.

[lmame]

Try dev rev II - 302, I deleted choseal's fix and replaced it by something else, if you could test (can't test it right now).