BUG: When using /go command From a PvP Zone

Put your bugs you find in osRose here

Moderators: osRose dev team, ospRose dev team, osiRose dev team, Moderators

BUG: When using /go command From a PvP Zone

Postby orlando619 on Sun Feb 03, 2013 3:05 pm

good day to all..

I'm using Dev Rev II and v307 of NaRose.
example:
When a player is using /go command from a PvP Zone area like Desert of the Dead, when he goes to junon, he can still kills players inside junon map.

Is this bug serversided or client sided ??

pls help me thnx :D
orlando619
Jelly Bean
Jelly Bean
 
Posts: 19
Joined: Tue Dec 13, 2011 2:34 am

Re: BUG: When using /go command From a PvP Zone

Postby observe on Mon Feb 04, 2013 5:45 pm

orlando619 wrote:good day to all..

I'm using Dev Rev II and v307 of NaRose.
example:
When a player is using /go command from a PvP Zone area like Desert of the Dead, when he goes to junon, he can still kills players inside junon map.

Is this bug serversided or client sided ??

pls help me thnx :D


i think this is server related.
if possible try to reset his pvp_id to default
or prevent the /go command on pvp maps
observe
osRose dev
osRose dev
 
Posts: 194
Joined: Thu Sep 17, 2009 10:28 am
Location: The Netherlands

Re: BUG: When using /go command From a PvP Zone

Postby orlando619 on Fri Feb 08, 2013 8:05 am

and also ..

when a player is on a non-pvp map, when he uses /go command to go on a pvp map like training grounds, pvp status of a player in not active. as easy as 1 2 3, when both players from junon polis map, when these two players use /go command to go to training grounds, they can't pvp inside the training grounds.
It seems that training ground is like a non-pvp map when using /go command to go there.

also, when a player does /go command to go to a non-pvp map, a player can pk(player kill) other players inside a non-pvp map.

i think the serverside or the clientside can't trigger the pvp status of a player when using /go command ..

can you guys fixed these bugs for me ??XD

more power and Godbless to all ..
orlando619
Jelly Bean
Jelly Bean
 
Posts: 19
Joined: Tue Dec 13, 2011 2:34 am

Re: BUG: When using /go command From a PvP Zone

Postby Circa on Fri Feb 08, 2013 8:08 am

or you can look up teh code in gmcmds.cpp and try and fix it :) :P, i'll take a gander at it see what i find.
Circa
Clown
Clown
 
Posts: 404
Joined: Sun Aug 23, 2009 5:52 am
Location: CA

Re: BUG: When using /go command From a PvP Zone

Postby wolfwing on Fri Feb 08, 2013 9:14 am

Or you shouldn't give GM commands to your players at all like your supposed to.
wolfwing
Clown
Clown
 
Posts: 502
Joined: Tue Mar 03, 2009 9:50 am

Re: BUG: When using /go command From a PvP Zone

Postby PurpleYouko on Fri Feb 08, 2013 2:48 pm

exactly.

Don't let players use /go at all.

Make them buy scrolls or something
Need to lookup information on NARose items, skills, quests?
Now featuring a newly completed skill tree for all classes
Formatting fixed for different resolutions
Image

"A Gazelle is nothing but a giraffe plotted logarithmicaly"
User avatar
PurpleYouko
Rose Guru
Rose Guru
 
Posts: 4733
Joined: Fri Aug 10, 2007 2:05 pm

Re: BUG: When using /go command From a PvP Zone

Postby Circa on Fri Feb 08, 2013 8:36 pm

well still even lets say, I started a legit server, and I made someone a GM, most likely someone I already know that wouldn't give out items blah blah blah. If he found out about this bug with the /go command, then that person would troll with it then tell me about it then fix it, but still it is a bug :P.
Circa
Clown
Clown
 
Posts: 404
Joined: Sun Aug 23, 2009 5:52 am
Location: CA

Re: BUG: When using /go command From a PvP Zone

Postby rl2171 on Sat Feb 09, 2013 9:36 pm

If you don't want someone to use the GO command to a PvP zone, change it in the sql in the isactive part from 1 to 0, then it won't show up on the list of locations they can go to. Simple :)
Image
rl2171
Admin
Admin
 
Posts: 1706
Joined: Mon Aug 06, 2007 5:17 pm
Location: Sacramento, CA USA - GMT-8

Re: BUG: When using /go command From a PvP Zone

Postby Circa on Mon Feb 11, 2013 9:00 pm

Add this line,
You should find it in gmcmds.cpp around lines 1320-1335ish
is in the else if for /go command incase you can't find it.

This is also from dev rev 4, so it might not be located in the same place, and ,also, this function might not even exist in dev rev 2 lol.
I also assume that this function is taking the consideration of the actual map you /go'd so you can test it out lol.

The only thing i did was just recompiled and returned no errors, probably someone else can verify that using that function would change the players pvp_id to what it needs to be that would be cool lol. cuz I didn't wanna do something that an existing function does already. Which is just check the map if it allows pvp or not and then change the pvp_id to whatever it needs to be. So, test it out orlando and tell me if it works :P, if not just remove it and recompile it again if it makes things worse.
  1.  
  2.        fPoint coord;
  3.             int map = atoi(row[1]);
  4.             coord.x = atoi(row[2]);
  5.             coord.y = atoi(row[3]);
  6.             SendPM(thisclient, "teleport to map: %i",map);
  7.             MapList.Index[map]->TeleportPlayer( thisclient, coord, false );
  8.             thisclient->pvp_id=thisclient->ReturnPvp(NULL,thisclient);
  9.             Log( MSG_GMACTION, " %s : /go %i" , thisclient->CharInfo->charname, loc);
  10.             DB->QFree( );
  11.             return true;
  12.  
  13.         }
  14.     }
  15.  
Circa
Clown
Clown
 
Posts: 404
Joined: Sun Aug 23, 2009 5:52 am
Location: CA


Return to Bugs

Who is online

Users browsing this forum: No registered users and 6 guests

cron