Revision Changes

[pepu]

Pepu, why did you just delete the quest folder...?
[Rev 30] Fixing Worldserver/quest/

I don´t know what did i do..because my pc crashed when i was uploading...
I won´t touch the svn anymore, i hate it
SORRY for my error :S

[lmame]

damn this is getting messy

Yeah quite... You should (I mean, all uploaders) stop for a couple of hours and see who uploads now. I count about 5 different uploaders that upload pretty much anything / everything and who (sometimes) delete what other are adding. Not talking of both SVN.

[Drakia]

Most of the changes I do are trying to fix problems caused by other people, or uploading tested code... Right now I'm about to upload an update to my IFO based spawn code, so that mob bosses spawn properly.

[Rev 31]
Updated IFO based spawning to use tactical points properly
Now it will take tacticalpoints basic kills before a tactical mob (boss) will spawn.

[Rev 32]
Removed maps from /go that don't exist.

[Rev 33]
Fixed /go 6, you spawned in a pyramid. Thanks Rob

[Rev 34]
Enabled IFO based spawning by default.
Me and Rob have tested it pretty thoroughly, there are still some missing features (Mob amount spawning) but nothing crashing. Spawns are better than the previous.
To re-enable old spawns, run list_spawnareas.sql and comment out "#define USEIFO" in sockets.h.

[Rev 35/36]
Rev 35 was just an SQL fix, rogue character found it's way into prose.sql
Rev 36 adds mob->amount useage to the IFO based spawning. It will now spawn mob->amount mobs but still stick to the limit for groups.

[Rev 39]
Fixed /npc, would die and/or have a memory leak if NPC id didn't exist.

[Rev 40]
Fixed clan window updating when creating a clan.

[pepu]

[Rev 37]
Skills Buffs Fix

[Rev 38]
HP/MP Fix

[Drakia]

Where'd you get those fixes from?

Well, just checked the MaxHP/MP ones, and the values returned are WAY off as compared to what you actually have in game. I have 2801 max in game, it says I should have 4346. MP is 444, it says 532.

[pepu]

it works for me...but i´ll check

[Drakia]

It shows as max ingame because most of the time it's calculating something above max.

[pepu]

[Rev 41]
Almost all debuffs working now (Mute,stun,poison,flaming not..)
Fixed some vars,and added vars for not working debuffs,to fix them tomorrow i think

[PurpleYouko]

well what do you know. I managed to upload a change to the SVN.

[rev 42] Modified GetNewItemSlot( CItem thisitem )
It now stacks items correctly when you pick them up or trade them with NPCs or other players.

The issue.
In the original code, it would return the first of the following that is encountered.
1) An empty slot
2) A slot containing items with the same item number (not necessarily item type)

The symptoms (fixed with this revision)
1) if you already have a stack of a certain type of item then pick up some more of the same, they only stack on top of the others IF an empty slot is not encountered first while parsing your inventory slots.
2) If you have a stack of Sapphire[1]( type 11, number 321) in your inventory and there is no free slot before the stack then you pick up, trade or buy a stack of bean bullets (type 12, number 321), the type is not checked and the stack of gems in incremented by the number of bullets that you bought. 999 Sapphire[1] for 2000 zuly? good deal eh?
This can also go the other way though which would not be so great for the person buying the Sapphires.

The fix
In this revision, the parsing of the slots is separated into two steps.
1) First it searches your inventory for an existing stack of items that match the item number AND item type of the ones being picked up, bought or traded. If a matching stack is found then this is returned as the slot number.
2) If no matching stack is found then it will parse your inventory one more time in search of an empty slot. If found then this will be returned.
3) Otherwise 0xffff; is returned.

I will be applying a similar fix to storage shortly.

[PurpleYouko]

[rev 43]
fixes some issues with items not stacking in storage.
It now parses the entire storage to find a matching item, then if unsuccessful or the item is unstackable, it parses again to find an open space.
This results in stacking being the preferred action rather than putting items into the first available slot whether it is a stack slot or an empty slot.

Code has been tried and tested for quite some time in my evo server so it is pretty stable.