Revisions

[PurpleYouko]

Haha This is funny

Line number On/Off | Expand/Contract | Select all

1.  
2. #define sExpandSummonGauge 62
3. #define sItemDropIncrease 63
4. #define sIncreaseSummonGauge 63

Methinks somebody screwed up here.
[hint] in STR_ABILITY.STL 62 = Summon Gauge Increase [/hint]

What do you mean [hint] isn't valid BB code???

[Drakia]

sExpandSummonGauge and SIncreaseSummonGauge were both already defined, I only added sItemDropIncrease, currently I'm trying not to take anything out, or delete defines, until I'm sure they won't be used

[PurpleYouko]

Yeah i know it wasn't you.
Still funny though.

[Drakia]

Indeed, but you also have to take into account that half of the defines are duplicates of other defines that are meant to cover the exact same thing, from the looks of it people didn't really look at what existed, they just added new defines. (Don't take into account my defines, I added them all because we now have grouped lists so we can systematically go through the source and get rid of calls to the other defines, replacing calls to the ones I made, and delete all the duplicates)

[PurpleYouko]

right.
At first it kind of confused me that we have so many defined values and loads of them represent the same numbers.

After a while though it started to click with me that each defined value is only used in its own specific context.

Makes perfect sense now, which is why I'm starting to see these stupid errors everywhere.

[Drakia]

So, get a chance to look at that skill code I added?

[PurpleYouko]

Not really

I've been rather busy all day.

I just about found the time to merge the SVN into my own code and get it to compile and run. That was as far as i went today.
Now I'm about to head for home and spend the next 5 hours laying laminate flooring.

Oh the joys of buying a fixer upper house.

[Blackdpd]

lool ..

going good with the kitchen then?

Blackdpd `

[PurpleYouko]

The kitchen is a later project.
I'm working on the guest bedroom and bathroom right now.
The mother in-law will be coming to visit in a couple weeks so i have to get it finished ASAP

[Drakia]

Bah, Purple, you redefined GetXPRate, added a new xprate = in SetStats, and killed compiling XPRate was supposed to be in Stats, not Info. I'd already added GetXPRate, and Stats->xprate = 1; // GetXPRate(); at the bottom of SetStats (No items in pRose give XP rate boosts)