Revisions

Welcome in the osRose emulator Project.

Moderators: osRose dev team, ospRose dev team, osiRose dev team, Moderators

Re: Revisions

Postby Blackdpd on Fri Jun 06, 2008 11:59 pm

lol now they do... ( just kidding )
the xprate boosts does not even work in osirose so it does not even work with osprose..

Blackdpd `
User avatar
Blackdpd
El Verloon Marshall
El Verloon Marshall
 
Posts: 900
Joined: Sun Jan 27, 2008 10:06 pm
Location: The Netherlands

Re: Revisions

Postby Drakia on Sat Jun 07, 2008 12:10 am

PY just recently wrote the XP rate code...
My favorite skill is scaring new users away.
If you haven't SEARCHED expect me to yell at you.
Image
Drakia
ospRose dev team
ospRose dev team
 
Posts: 1614
Joined: Tue Sep 18, 2007 6:53 am
Location: Nanaimo, BC, Canada

Re: Revisions

Postby Sethanye on Sat Jun 07, 2008 1:40 pm

well i wouldnt call it recently, his server had it like for a couple months already
~ Learning Flash ~ Anyone Know Any Good Tutorial DVDs? ~
Image
"Come Into My Dream, Let Me Show You Where I've Been.
Its You And Me I've Seen, Let Me Tell You What I Mean."
User avatar
Sethanye
Neko Chan
Neko Chan
 
Posts: 2603
Joined: Fri Jan 18, 2008 11:23 am
Location: ~ Resident Graphics Artist ~

Re: Revisions

Postby PurpleYouko on Sat Jun 07, 2008 4:28 pm

Drakia wrote:Bah, Purple, you redefined GetXPRate, added a new xprate = in SetStats, and killed compiling :( XPRate was supposed to be in Stats, not Info. I'd already added GetXPRate, and Stats->xprate = 1; // GetXPRate(); at the bottom of SetStats (No items in pRose give XP rate boosts)

Oh crap.

How did I manage to redefine GetXPRate?
I only committed two cpps
Playerstats.cpp and Serverfunctions.cpp
The GetXPRate function should be identical. I haven't changed in in like forever. It's the same now as it was when I put it into my evo server about 8 months ago.

Plus I updated the SVN files before copying the new code into them so I don't understand how this can be happening.
I literally downloaded Playerstats.cpp from the SVN, added 4 lines of code to it then re-committed it.
I didn't change a damn thing related to xprate

In my original code, my xprate is and always has been in Info rather than Stats.
It physically won't run on my computer if i put it into Stats. It just returns garbage and gives me an xprate of 30 no matter what I equip.

Anyway sorry about causing a problem. I just don't understand how it happened

What exactly did you have to change?
It's pointless me looking in the SVN for it since the stuff that comes through to me on an update is exactly what i re-committed. I didn't change it.
SVN still confuses me. :(
Need to lookup information on NARose items, skills, quests?
Now featuring a newly completed skill tree for all classes
Formatting fixed for different resolutions
Image

"A Gazelle is nothing but a giraffe plotted logarithmicaly"
User avatar
PurpleYouko
Rose Guru
Rose Guru
 
Posts: 4733
Joined: Fri Aug 10, 2007 2:05 pm

Re: Revisions

Postby Drakia on Sat Jun 07, 2008 8:23 pm

Well, GetXPRate was already in playerstats.cpp (I think it was that file), but in a different spot than you added it. So I had to remove the second one that you added with this rev. And currently all the XPRate vars are in Stats, not Info, so when you added Info->xprate at the bottom of SetStats, it killed compiling because that isn't defined.
My favorite skill is scaring new users away.
If you haven't SEARCHED expect me to yell at you.
Image
Drakia
ospRose dev team
ospRose dev team
 
Posts: 1614
Joined: Tue Sep 18, 2007 6:53 am
Location: Nanaimo, BC, Canada

Re: Revisions

Postby PurpleYouko on Sun Jun 08, 2008 3:16 pm

Drakia wrote:Well, GetXPRate was already in playerstats.cpp (I think it was that file), but in a different spot than you added it. So I had to remove the second one that you added with this rev. And currently all the XPRate vars are in Stats, not Info, so when you added Info->xprate at the bottom of SetStats, it killed compiling because that isn't defined.

Except that i didn't add it.
The SVN downloaded it that way.
That's what I don't understand.
Admittedly, my own code (stored on a different drive in my PC) is made with the Info structure because it wouldn't work in stats, but as far as i can remember i have never put that code over to the SVN files.
I have been trying to be careful to only copy over stuff that I actually changed before committing.

Apparently not careful enough though. :(
Need to lookup information on NARose items, skills, quests?
Now featuring a newly completed skill tree for all classes
Formatting fixed for different resolutions
Image

"A Gazelle is nothing but a giraffe plotted logarithmicaly"
User avatar
PurpleYouko
Rose Guru
Rose Guru
 
Posts: 4733
Joined: Fri Aug 10, 2007 2:05 pm

Re: Revisions

Postby Drakia on Sun Jun 08, 2008 8:44 pm

Ah, I thought you had added it to try and complete the XPRate code :/ Owell, if things get screwed up, they can always be fixed, that's why we use SVN in the first place :) So don't worry about it, just keep submitting and if anything is wrong, it'll get fixed.
Also, I recommend clicking on the folder you use for SVN, updating, and then clicking "Revert" in the SVN menu. It'll get rid of any and all changes from the base revision that it just updated to, so you won't need to worry about any rogue code being in there anymore.
My favorite skill is scaring new users away.
If you haven't SEARCHED expect me to yell at you.
Image
Drakia
ospRose dev team
ospRose dev team
 
Posts: 1614
Joined: Tue Sep 18, 2007 6:53 am
Location: Nanaimo, BC, Canada

Re: Revisions

Postby PurpleYouko on Mon Jun 09, 2008 2:03 pm

The xprate code has always been 100% complete and working perfectly at my end.
It is working on my test server too. just get one of those jewelry items from Mina in Zant to check it out. (you will need to use neoncube to patch to version 118 first though)

I think what caused the issue initially was that when i posted up the code for the XPRate modification (rather than putting it into the SVN myself) you (or somebody else) applied the code to your version and then committed it.
Naturally this ended up slightly different than my original. (GetXPRate in a different position, Stats structure instead of Info structure and so on)

What I need to be careful of is that the code that i keep for SVN actually matches the SVN to avoid this happening. :)
I'm going to start today by modifying my copy to match what should be there.
Need to lookup information on NARose items, skills, quests?
Now featuring a newly completed skill tree for all classes
Formatting fixed for different resolutions
Image

"A Gazelle is nothing but a giraffe plotted logarithmicaly"
User avatar
PurpleYouko
Rose Guru
Rose Guru
 
Posts: 4733
Joined: Fri Aug 10, 2007 2:05 pm

Re: Revisions

Postby lmame on Mon Jun 09, 2008 4:06 pm

Do you update your code before submitting? Sometimes that could explain differences in version.
The world is full of love and peace ^_^
Image
User avatar
lmame
Admin
Admin
 
Posts: 8997
Joined: Mon Aug 06, 2007 4:42 pm
Location: July City

Re: Revisions

Postby PurpleYouko on Mon Jun 09, 2008 4:24 pm

what i have been doing is to update the SVN then add/modify my changes, then check that there is no new update then finally commit it again.
I think the problem is that the SVN is merging with my files without me noticing so when I commit it, it contains (for example) two complete GetXPRate() functions in totally different places.
Need to lookup information on NARose items, skills, quests?
Now featuring a newly completed skill tree for all classes
Formatting fixed for different resolutions
Image

"A Gazelle is nothing but a giraffe plotted logarithmicaly"
User avatar
PurpleYouko
Rose Guru
Rose Guru
 
Posts: 4733
Joined: Fri Aug 10, 2007 2:05 pm

PreviousNext

Return to Support - OspRose Emulator

Who is online

Users browsing this forum: No registered users and 8 guests

cron