[BUG]Quest System

I'm sure there will be a TON of bugs discovered. List them here and we will cross them off the list as they are fixed.

[BUG]Quest System

Postby Dibella on Sun Nov 12, 2017 9:09 am

Greetings,

When you pick up a quest, any quest... Then it should pop up in the client Quest log. But this does not.
I have a feeling that it is server side, as I added completely random quests to my character VIA the Database and then when I take a new quest, every quest linked to my character gets removed in the database, and the new quest does not get added. I have a feeling this might be a packet mismatch or something like that, but I am unsure.

Any input, help, spiritual guidance, emotion support or/and paypal donations are accepted.

Much Love,
Dibella
Dibella
Smoulie
Smoulie
 
Posts: 46
Joined: Sat Apr 13, 2013 8:49 pm

Re: [BUG]Quest System

Postby PurpleYouko on Mon Nov 13, 2017 3:32 pm

did you also set all the quest flags correctly?

Just adding quests in the database doesn't give you them. The flags are what actually store your progress.
Figuring out the flags to set is not an easy progress. I have made tools for doing that and it still takes a LONG time to get them set up properly for a single quest chain. And yes you often do have to set flags for the entire chain to make it work.
It has a habit of backchecking quests in the chain and will seemingly randomly delete stuff in an attempt at housekeeping if it detects flags that are incorrectly set.

Quests are a very complicated mechanism. I don't recommend shortcutting them by adding stuff directly into the database. It's a potential minefield that could well end up making the character unplayable at worst case.

Every test I have run on quests has shown that they all work when done in the normal way. With entering stuff into the database all bets are off. :?
Need to lookup information on NARose items, skills, quests?
Now featuring a newly completed skill tree for all classes
Formatting fixed for different resolutions
Image

"A Gazelle is nothing but a giraffe plotted logarithmicaly"
User avatar
PurpleYouko
Rose Guru
Rose Guru
 
Posts: 4733
Joined: Fri Aug 10, 2007 2:05 pm

Re: [BUG]Quest System

Postby Dibella on Mon Nov 13, 2017 3:36 pm

Can you please guide me as to what I am doing wrong as taking a normal quest from like the fairy or the Job Identification quest doesn't add it to my quest log.

I have the fresh copies from the Github that you set up... Maybe your version is more updated than the github one.

Please advise.

Thank you so much for the patience that you have with me xD

Kindest Regards,
Dibella
Dibella
Smoulie
Smoulie
 
Posts: 46
Joined: Sat Apr 13, 2013 8:49 pm

Re: [BUG]Quest System

Postby PurpleYouko on Mon Nov 13, 2017 11:20 pm

i will look into it as soon as I get the chance. may not be this week though. Work is piling up right now.
Need to lookup information on NARose items, skills, quests?
Now featuring a newly completed skill tree for all classes
Formatting fixed for different resolutions
Image

"A Gazelle is nothing but a giraffe plotted logarithmicaly"
User avatar
PurpleYouko
Rose Guru
Rose Guru
 
Posts: 4733
Joined: Fri Aug 10, 2007 2:05 pm

Re: [BUG]Quest System

Postby Dibella on Tue Nov 14, 2017 5:32 pm

Hey, that's awesome and thank you so much !.

And this isn't that major, your work is #1 Priority ! :)

Have a lovely week ahead !

Kindest Regards with a hint of love,
Dibella
Dibella
Smoulie
Smoulie
 
Posts: 46
Joined: Sat Apr 13, 2013 8:49 pm

Re: [BUG]Quest System

Postby PurpleYouko on Thu Nov 16, 2017 3:40 pm

Updated the server repo to match my development files.
Nothing related to quests though. most of the changes were related to the recent BuffBots stuff that was discussed a couple of months ago.

haven't had the chance to run any tests yet or compare client side files.
Need to lookup information on NARose items, skills, quests?
Now featuring a newly completed skill tree for all classes
Formatting fixed for different resolutions
Image

"A Gazelle is nothing but a giraffe plotted logarithmicaly"
User avatar
PurpleYouko
Rose Guru
Rose Guru
 
Posts: 4733
Joined: Fri Aug 10, 2007 2:05 pm

Re: [BUG]Quest System

Postby Dibella on Fri Nov 17, 2017 11:40 am

Hey PY well I downloaded your Character Server update...

And like all things rose (excuse my frustration)... xD Something went wrong.

When you login to create a character, as soon as you click "Create Character" then the Character server crash... now it looks like the WorldServer doesnt know what the avatar name is yet, as it wants to try and save the avatar, but it says;

Saving Avatar " " || Avatar " " not found.

And the only thing that Character server says is the the account has been logged in.

xD so gonna try now without creating a char and using a pre existing one.

Now creating a new character, selecting an old one... the process just stucks at WAITING.
Dibella
Smoulie
Smoulie
 
Posts: 46
Joined: Sat Apr 13, 2013 8:49 pm

Re: [BUG]Quest System

Postby PurpleYouko on Fri Nov 17, 2017 3:22 pm

I only uploaded a few changes to worldserver source. It shouldn't make any difference to anything else.

Either way i have a little time today so i will test everything that's on my repo and update stuff where necessary

[ABE]
So i fired it up to test and was unable to advance my missing children quest chain. Tried 3 times and it just didn't register that I had talked to francis plus the Client log files showed a Quest Failure event.
Turned on quest debug mode (/dquest) and tried again. It worked perfectly. Hmmm... Something weird here.
Searched for all occurrences of GServer->questdebug and found this
  1.  
  2. //QSD Quests
  3. int CPlayer::ExecuteQuestTrigger(dword hash,bool send_packet, UINT index)
  4. {
  5.     //Code that actually works. Taken from KTRose
  6.     CQuestTrigger* trigger = NULL;
  7.     CQuestTrigger* nexttrigger = NULL;
  8.     CheckQuest = -1;
  9.     if (GServer->questdebug)
  10.  
  11.     for(unsigned j=0; j < GServer->TriggerList.size(); j++)
  12.     {
  13.         if (GServer->TriggerList.at(j)->TriggerHash == hash)
  14.         {
  15.             trigger = GServer->TriggerList.at(j);
  16.             nexttrigger = GServer->TriggerList.at(j + 1);
  17.             break;
  18.         }
  19.     }
  20.     if (trigger == NULL) return QUEST_FAILURE;
  21.  

in Playerfunctions.cpp
Basically this code stops it from running the loop that locates the quest unless GServer->questdebug is true.
It looks like somehow a log message got deleted leaving the questdebug conditional free to completely fuck up quests :shock:
Fortunately all we need to do is delete the conditional or comment it out
  1. //if (GServer->questdebug)


Recompiled and tested. Quest updated perfectly

now to double check all the files and make sure i didn't accidentally upload something horrible yesterday ;)

one thing you should check is that your conf files didn't get changed. if you just downloaded the entire repo they would probably be set up wrong for you.
Need to lookup information on NARose items, skills, quests?
Now featuring a newly completed skill tree for all classes
Formatting fixed for different resolutions
Image

"A Gazelle is nothing but a giraffe plotted logarithmicaly"
User avatar
PurpleYouko
Rose Guru
Rose Guru
 
Posts: 4733
Joined: Fri Aug 10, 2007 2:05 pm

Re: [BUG]Quest System

Postby PurpleYouko on Fri Nov 17, 2017 4:21 pm

All changed stuff has been uploaded to the repo. Including executables and a couple of STB/STL changes that I made in preperation for future modifications to spawning
Need to lookup information on NARose items, skills, quests?
Now featuring a newly completed skill tree for all classes
Formatting fixed for different resolutions
Image

"A Gazelle is nothing but a giraffe plotted logarithmicaly"
User avatar
PurpleYouko
Rose Guru
Rose Guru
 
Posts: 4733
Joined: Fri Aug 10, 2007 2:05 pm

Re: [BUG]Quest System

Postby Dibella on Wed Nov 29, 2017 6:34 pm

Thank you so much PY !!!

WE love you a lot !

You have a special place here in my heart :)

Regards,
Dibella ! <3
Dibella
Smoulie
Smoulie
 
Posts: 46
Joined: Sat Apr 13, 2013 8:49 pm


Return to BUGS

Who is online

Users browsing this forum: No registered users and 1 guest

cron