[FIXED] Database Bugs

[adosorken]

Thu Aug 25 10:03:16 2016 - CCharModelData loading normal file type for 3DDATA\NPC\LIST_NPC.CHR
Thu Aug 25 10:03:16 2016 - CCharModelData Failed to load normal file type for 3DDATA\NPC\LIST_NPC.CHR
Thu Aug 25 10:03:16 2016 - CCharModelData loading VFS file type for 3DDATA\NPC\LIST_NPC.CHR

Keep in mind that I have not yet unloaded the VFS. I only just barely found the tool that could do the job, which, of course, is Sniper's VFSEditor.exe (Universal VFS Extractor.exe and VFS Extractor.exe both crash). I will copy these files into the directory and see if the problem still manifests.

[adosorken]

Okay... now I see what's wrong. It looks like there may be an error in the VFS file itself.

[PurpleYouko]

so you still couldn't extract the VFS fully?

Looks like I might have to upload the whole extracted VFS some place.
I'm actually considering deleting the entire VFS and just working from files anyway

Trouble is it's almost 2gig on my HD lol

Ah what the heck. I'm zipping it up and uploading it to my mega account. I'll let you know when its ready

[adosorken]

Not only can I not extract the VFS fully, but this is where TRose.exe is crashing. I am assuming that the uploaded file is corrupt in some way. Looks like the index is loading fine, but the data itself is corrupt.

[PurpleYouko]

if you are crashing at this point and you haven't yet extracted your VFS then you have hit the bug that I already described in my introduction post.

There is at least one file type that cannot be loaded from VFS. I don't know which type as i haven't bothered to put in any time to figure it out. I just know it always crashes if I don't have a fully extracted VFS.

From your information I conclude that the actual bug is being caused by not having a valid check to see if the file (of the unknown type) is missing in normal file format. I had to go through them all and add this kind of check for each file type one by one and I obviously missed at least one. It will get fixed eventually but it's WAY the heck down low in terms of things that i need to work on.

[WiseGuy]

Thanks PY
I solved the error. My bad, I have wrong extraction the client

but found missing another sql, storage

[PurpleYouko]

Thanks PY
I solved the error. My bad, I have wrong extraction the client

but found missing another sql, storage

We don't use the "storage" table any more. My server uses "charstorage" and "backupstorage"

Just checked and found some legacy code in playerdata.cpp that was still attempting to save to it.
I have commented that code out and pushed the modified file to the repo.

Guess that won't help if you are using my binaries though. Better update worldserverVS.exe too I suppose.